Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend integration tests for summary and zoom view #1931

Closed
vvidday opened this issue Mar 6, 2023 · 0 comments · Fixed by #2015
Closed

Update frontend integration tests for summary and zoom view #1931

vvidday opened this issue Mar 6, 2023 · 0 comments · Fixed by #2015

Comments

@vvidday
Copy link
Contributor

vvidday commented Mar 6, 2023

What feature(s) would you like to see in RepoSense

On the frontend, changes in the summary panel affect the zoom panel as well (e.g. changing the date range, changing the zoom range affect the commits shown in the zoom panel).

However, this functionality is not well tested in our current Cypress tests - for example, in chartView_zoomFeature.js, the test only checks if the zoom panel is visible after changing the zoom region, but does not check that the commits in the zoom panel actually correspond to the new zoom region.

It would be good to add test cases to test for this functionality.

Is the feature request related to a problem?

Other test cases, such as in #1930, rely on the correctness of this functionality between the summary and zoom panels.

If possible, describe the solution

We can add additional Cypress test cases for:

  • Check that changing the zoom range in the summary panel correctly filters the commits in the zoom panel
  • Check that changing the date range in the summary panel correctly filters the commits in the zoom panel

Ideally, these test cases wouldn't rely on any order/assumptions of the data, and thus won't break due to changes to the cypress branch.

If applicable, describe alternatives you've considered

Additional context

@vvidday vvidday self-assigned this Mar 6, 2023
@vvidday vvidday removed their assignment Jun 27, 2023
chan-j-d pushed a commit that referenced this issue Aug 31, 2023
…2015)

On the frontend, changes in the summary panel affect the zoom 
panel. However, this functionality is not well tested in our current 
Cypress tests.

Let's add additional Cypress tests for the changing of zoom and date 
range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Completed
1 participant