Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-96944 || Fix incorrect history field values #2106

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

pbortnik
Copy link
Collaborator

No description provided.

@pbortnik pbortnik requested a review from avarabyeu as a code owner November 25, 2024 08:47
private ServerSettingsConverter() {
//static only
}
public static final Function<ServerSettings, ServerSettingsResource> TO_RESOURCE = serverSettings -> new ServerSettingsResource(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 130).


public static final Function<List<ServerSettings>, Map<String, String>> TO_RESOURCE = serverSettings -> {
public static final Function<List<ServerSettings>, Map<String, String>> TO_RESOURCES = serverSettings -> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 108).

package com.epam.ta.reportportal.model.settings;

import javax.validation.constraints.NotEmpty;
import lombok.Data;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.


/**
* @author <a href="mailto:pavel_bortnik@epam.com">Pavel Bortnik</a>
*/
public class SettingsUpdatedEvent extends AroundEvent<ServerSettings> implements ActivityEvent {
public class SettingsUpdatedEvent extends AroundEvent<ServerSettingsResource> implements ActivityEvent {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 104).


public SettingsUpdatedEvent(ServerSettings before, ServerSettings after, Long userId,
public SettingsUpdatedEvent(ServerSettingsResource before, ServerSettingsResource after, Long userId,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 103).

@pbortnik pbortnik merged commit ec591c6 into develop Nov 25, 2024
6 checks passed
@pbortnik pbortnik deleted the EPMRPP-96944 branch November 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant