Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-91841 || HTTPS proxy support for client #205

Merged

Conversation

AmsterGet
Copy link
Member

@AmsterGet AmsterGet commented Jun 14, 2024

HTTPS proxy (axios/axios#4531) support for client JS.

@stevez
Copy link
Contributor

stevez commented Jun 21, 2024

Hey @AmsterGet, I pulled your branch and tested on my local, the code is still not working if I set http and http proxy environment variables. And finally I realize if you make following changes, then it will work.

In rest.js line 84:
Change delete config.proxy; to
config.proxy = false;

I can provide you the sample js file if you need

@AmsterGet AmsterGet force-pushed the feature/EPMRPP-91842-https-proxy-support-for-client branch from a6b7f4e to 8c623f8 Compare June 24, 2024 10:40
@AmsterGet
Copy link
Member Author

Hey @AmsterGet, I pulled your branch and tested on my local, the code is still not working if I set http and http proxy environment variables. And finally I realize if you make following changes, then it will work.

In rest.js line 84: Change delete config.proxy; to config.proxy = false;

I can provide you the sample js file if you need

Hi @stevez !
Thanks for checking this and for providing a hint!

@AmsterGet AmsterGet force-pushed the feature/EPMRPP-91842-https-proxy-support-for-client branch from 8c623f8 to 1255a6c Compare July 31, 2024 16:09
@AmsterGet AmsterGet merged commit dfffa3d into develop Jul 31, 2024
5 of 6 checks passed
@AmsterGet AmsterGet deleted the feature/EPMRPP-91842-https-proxy-support-for-client branch July 31, 2024 16:11
@AmsterGet
Copy link
Member Author

Can be also related to axios/axios#5256

AmsterGet added a commit that referenced this pull request Sep 16, 2024
AmsterGet added a commit that referenced this pull request Sep 16, 2024
AmsterGet added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants