Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony to 5.1 #248

Closed
wants to merge 2 commits into from
Closed

Conversation

marmichalski
Copy link
Contributor

Related to #206, #239

@marmichalski
Copy link
Contributor Author

Seems there is an issue with 5.1. Will resolve it when I'm back at keyboard 😎

@akondas
Copy link
Member

akondas commented Aug 20, 2020

🤔 recently a lot of this type of errors after updates

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #248 into master will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
- Coverage     99.68%   99.63%   -0.05%     
- Complexity     1513     1514       +1     
============================================
  Files           250      250              
  Lines          4404     4404              
============================================
- Hits           4390     4388       -2     
- Misses           14       16       +2     
Impacted Files Coverage Δ Complexity Δ
src/Query/Admin/Proxy/Model/Package.php 80.00% <0.00%> (-20.00%) 4.00 <1.00> (+1.00) ⬇️
src/Command/ProxySyncMetadataCommand.php 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
src/Security/GitLabAuthenticator.php 100.00% <100.00%> (ø) 7.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139c4f3...a75f14a. Read the comment docs.

@akondas akondas mentioned this pull request Sep 1, 2020
8 tasks
@karniv00l karniv00l mentioned this pull request Sep 1, 2020
@karniv00l
Copy link
Contributor

I couldn't push directly so I've made PR out if this #250

@akondas
Copy link
Member

akondas commented Sep 1, 2020

Thanks, will be merged in #250

@akondas akondas closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants