Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use "-" as alternative for subdomain separator to simplify certificate handling #374

Closed
jmalinens opened this issue Jan 12, 2021 · 2 comments · Fixed by #375
Closed

Comments

@jmalinens
Copy link
Contributor

This can help to make an easier deployment of repman for some people.
My use case:
We don't have easy and ergonomic way to generate letsencrypt certs for many domains but we have *.devdomain.com cert readily available so we prefer to use one existing certificate

Example
https://myorganization-repo-repman.devdomain.com

jmalinens pushed a commit to jmalinens/repman that referenced this issue Jan 12, 2021
@akondas
Copy link
Member

akondas commented Jan 13, 2021

If it could be done as a configuration parameter then I'm in favor. However, I see a problem with authoring composer. Because individual tokens must have a separate subdomain.

jmalinens pushed a commit to jmalinens/repman that referenced this issue Jan 14, 2021
jmalinens pushed a commit to jmalinens/repman that referenced this issue Jan 14, 2021
@jmalinens
Copy link
Contributor Author

I understand Your concern!
This feature is meant only for self hosted version.
I think majority of self hosted versions will have only 1 organization.

I have updated security.yaml to also use %domain_separator% in regexes instead of hardcoded [\.\-] to avoid issues that some urls are allowed from both domains.
I have also updated comment in services.yaml explaining that alternative separator can be used in self-hosted cases for 1 organization installs.

akondas pushed a commit that referenced this issue Jan 18, 2021
…rts #374 (#375)

Authored-by: Juris Malinens <juris.malinens@co.inbox.lv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants