[bug] Avoid leaking lint command after #136 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
ryantm
and removed request for
a team
I examined the whl and thought I was safe because no lint.py was in the dist, but I neglected to grep so I missed entrypoints
blast-hardcheese
force-pushed
the
dstewart/bug/avoid-leaking-lint-command
branch
from
002d977 to
803b807
Compare
lhchavez
approved these changes
Feb 15, 2025
blast-hardcheese
force-pushed
the
dstewart/bug/avoid-leaking-lint-command
branch
from
803b807 to
1c55778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In an attempt at good quality-of-life tooling, I optimistically added a
lintcommand, invoked viauv run lint. I thought since I wasn't shipping thelint.pyI was safe, but it turns out I was shipping the entrypoints via the package META.What changed
lint.pyinto a proper local package, scoped to[dev]Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it