Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get libpython3.9 in CI #29

Closed
wants to merge 3 commits into from
Closed

Get libpython3.9 in CI #29

wants to merge 3 commits into from

Conversation

noneofyourbusiness1415252
Copy link
Contributor

trying to fix the issue with macos-latest in github actions

@noneofyourbusiness1415252 noneofyourbusiness1415252 marked this pull request as ready for review March 9, 2024 21:39
@noneofyourbusiness1415252 noneofyourbusiness1415252 changed the title Update validation.yml Get libpython3.9 in CI Mar 9, 2024
@noneofyourbusiness1415252 noneofyourbusiness1415252 mentioned this pull request Mar 9, 2024
Closed
@noneofyourbusiness1415252
Copy link
Contributor Author

noneofyourbusiness1415252 commented Mar 10, 2024 •
edited
Loading

oh wait lol it's just an issue on my patch-2 branch because I still had node-calls-python installed which needs libpython. It'd still be useful to note in future that MacOS python doesn't seem to come with libpython by default. So, if you want to merge in aecba1a (to keep yapf but get better performance), you'll have to merge #29 first.

@blast-hardcheese
Copy link
Contributor

I'll be reviewing #25 shortly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noneofyourbusiness1415252 @blast-hardcheese