Move JDBC connector deps to :dev alias

[PavlosMelissinos]

No description provided.

[PavlosMelissinos]

konserve-jdbc didn't have a dev profile, so I made one.

FYI, the dependencies will obviously have to be added to the dev alias for every library that uses konserve-jdbc

[whilo]

@TimoKramer @jsmassa Does that make sense to you?

[TimoKramer]

We'll need the drivers in the test-alias as well otherwise the tests won't run.

[TimoKramer]

And some update in the documentation would be good where you describe the breaking change and the need to add the drivers manually

[PavlosMelissinos]

We'll need the drivers in the test-alias as well otherwise the tests won't run.

In theory you can use something like clj -M:dev:test to stack the aliases but I'm not sure how you actually run the tests (you're using an orb, right?)

edit: nevermind, found it! I'm going to change clojure -M:test -m kaocha.runner "$@" in bin/kaocha to clojure -M:dev:test -m kaocha.runner "$@"

And some update in the documentation would be good where you describe the breaking change and the need to add the drivers manually

Good point!

Would a note in README.md suffice? It would be nice to be included in the next release notes too.

Also are you sure you're ok with introducing this breaking change? I suppose most users will provide their own jdbc driver(s) as direct dependencies, so few apps will actually break but you never know...

[TimoKramer]

In theory you can use something like clj -M:dev:test to stack the aliases but I'm not sure how you actually run the tests (you're using an orb, right?)

right, I am hesitant to change the orb

Would a note in README.md suffice? It would be nice to be included in the next release notes too.

Right, we'll add it prominently to the README and we'll put it in the commit message and we'll announce it on our slack channel.

Also are you sure you're ok with introducing this breaking change?
It's the right way to go so I am for it but I guess some people are relying on our dependencies. Still we were not good so far with keeping the deps up to date so most users should have overwritten them anyway.

[PavlosMelissinos]

Alright @TimoKramer , please check again, I think I've addressed everything!

By the way I ran ./bin/run-integrationtests from the main branch but it fails. Something is off with networking because it doesn't "see" the postgres container for some reason.

Apparently it's working for you so it shouldn't matter, it just means that I can't test that everything still works as expected.

[TimoKramer]

I think we are good. Just minor changes in wording. @alekcz @jsmassa What do you think?

[TimoKramer]

One thing you @PavlosMelissinos could change is to increase the minor release version in the build.clj to 0.2.

[PavlosMelissinos]

@TimoKramer done, I think

[TimoKramer]

Merge? @whilo

[whilo]

Thanks a lot for the PR!