feat: add doc on cpu feature check #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
Sep 27, 2024
✅ Deploy Preview for troubleshoot-sh ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
laverya
reviewed
Sep 27, 2024
| Supported CPU features (microarchitectures) set are: | ||
|
|
||
| - `x86-64` | ||
| - `x86-64-v2` |
There was a problem hiding this comment.
Can you search for specific flags or just feature levels?
There was a problem hiding this comment.
The latter. But it can be, can you think in a good way to call it ? I mean: supports x86-64-v2 is what I have chosen, how would it look like for a specific flag ?
There was a problem hiding this comment.
@laverya I have raised this, let me know if it is OK then I will make sure to amend this documentation: replicatedhq/troubleshoot#1631
There was a problem hiding this comment.
@laverya would you mind doing another review here ?
documents the new cpu feature check.
Co-authored-by: Andrew Lavery <laverya@umich.edu>
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-109040/preflight-for-x86-64-v2-support-in-embedded
branch
from
3f25b59 to
b560ac6
Compare
banjoh
approved these changes
Oct 4, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-109040/preflight-for-x86-64-v2-support-in-embedded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documents the new cpu feature check.