This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Add ability for render steps to specify specific assets #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Add an
assets.v1
field tolifecycle.v1.render
. If set, the lifecycle step will render the assets on the step instead of the globalassets.v1
at the root of the spec.This can be used to break up rendering into several steps. This has a lot of use cases, the one I'm thinking of is
github
assethelm
asset usinglocal_path
andvalues_from
Essentially I want to be able to have something like the
ship init <chart>
workflow for anyship.yaml
application.How I Did it
present, we use the old behavior of rendering all the assets at the top
level
Still TODO
Other random stuff
weren't testing anything, but seemed to imply that they were checking
render ouputs
How to verify it
ship init ~/go/src/github.com/replicatedhq/ship/integration/base/direct-render/input/.ship/ship.yml
Description for the Changelog
Add an
assets.v1
field tolifecycle.v1.render
. If set, the lifecycle step will render the assets on the render step instead of the globalassets.v1
at the root of the spec.