This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
use the app slug graphql query for 'replicated.app/slug' upstreams #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
pkg/specs/replicatedapp/graphql.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| if shipResponse.Errors != nil && len(shipResponse.Errors) > 0 { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
laverya
force-pushed
the
use-app-slug-graphql-query
branch
2 times, most recently
from
ec5f89d to
d573888
Compare
| return nil, err | ||
| } | ||
|
|
||
| if shipResponse.Errors != nil && len(shipResponse.Errors) > 0 { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
persist licenseID and AppSlug in metadata
laverya
force-pushed
the
use-app-slug-graphql-query
branch
from
d228fd8 to
971aecf
Compare
Rob0h
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
replicated.app/app-slug/?license_id=IDupstreams now use a new graphql query.How I Did it
A new code path has been added to use a different query if an app slug is provided and a channel ID is not.
How to verify it
Look at the new init_app integration test, and at the code in
pkg/specs/replicatedapp/graphql.go.Description for the Changelog
replicated.app/app-slug/?license_id=IDupstreams are supported.Picture of a
BoatShip (not required but encouraged)