This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
support additional replicated.app upstream formats #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
approved these changes
Feb 26, 2019
pkg/specs/replicatedapp/resolver.go
Outdated
| return nil, err | ||
| if selector.InstallationID == "" { | ||
| debug.Log("event", "spec-resolve", "from", selector, "error", err) | ||
| fmt.Printf("Please enter a license id to continue: ") |
There was a problem hiding this comment.
How about "Please enter your license to continue: " for this message?
dexhorthy
reviewed
Feb 26, 2019
pkg/specs/replicatedapp/resolver.go
Outdated
| return nil, err | ||
| if selector.InstallationID == "" { | ||
| debug.Log("event", "spec-resolve", "from", selector, "error", err) | ||
| fmt.Printf("Please enter your license to continue: ") |
There was a problem hiding this comment.
we use the mitchellh/cli components for prompting elsewhere in this project.
They are a little more succinct, and make this code easily testable
There was a problem hiding this comment.
Cool, I'll find that to copy it!
laverya
force-pushed
the
additional-replicated-app-url-formats
branch
from
9912285 to
7f23457
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Support
replicated.app/app_name_hereformats. If a license ID is required, ship will prompt for it on the command line.How I Did it
replicated.app/is now used for customer_id if not provided.How to verify it
ship init replicated.app/myappnameand follow the promptsDescription for the Changelog
Additional ship app upstream formats are supported.
Picture of a Boat (not required but encouraged)