Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Fix the ship icon #845

Merged
merged 8 commits into from
Feb 26, 2019
Merged

Fix the ship icon #845

merged 8 commits into from
Feb 26, 2019

Conversation

Rob0h
Copy link
Contributor

@Rob0h Rob0h commented Feb 26, 2019

What I Did

  • Fix the ship icon

How I Did it

  • Move all the logic for the chart name and icon to the /metadata
  • Remove the /helm-metadata and /channel endpoints
  • Include, serve, and use the ship-logo

How to verify it

  • Run ship pointed to a vendor app with an icon
  • Run ship with the --set-channel-icon and --set-channel-name flags

Description for the Changelog

Fix the ship icon

Picture of a Boat (not required but encouraged)

🛶

@Rob0h Rob0h requested a review from GraysonNull February 26, 2019 17:38
@Rob0h Rob0h merged commit fd732ea into replicatedhq:master Feb 26, 2019
@Rob0h Rob0h deleted the fix/icon branch February 26, 2019 19:43
@Rob0h Rob0h mentioned this pull request Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants