This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
copy, not symlink, local files #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 nice. There are some other weird things that happen with symlinks. In general we could probably stand to revisit how we can better support them at a project level, but for now I'm all for this. |
Rob0h
reviewed
Feb 26, 2019
| debug := level.Debug(g.Logger) | ||
| debug.Log("event", "localgetter.GetFiles", "upstream", upstream, "savePath", savePath) | ||
|
|
||
| // Remove the directory because go-getter wants to create it |
There was a problem hiding this comment.
is this comment and block still relevant?
Rob0h
approved these changes
Feb 26, 2019
Rob0h
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Instead of using gogetter for local files (which results in symlinks) recursively copy the directory. This fixes #843
How I Did it
How to verify it
Integration tests, including ones using local files, continue to pass.
ship init /path/to/yaml/filesworks.Description for the Changelog
Local upstreams are now copied instead of symlinked.
Picture of a Boat (not required but encouraged)