This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
don't render empty kubernetes yaml lists #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -121,16 +121,16 @@ func (l *Unforker) Execute(ctx context.Context, release *api.Release, step api.U | |||
| return nil | |||
| } | |||
|
|
|||
| func (l *Unforker) unforkBuild(kustomizePath string) ([]postKustomizeFile, error) { | |||
| debug := level.Debug(log.With(l.Logger, "struct", "daemonless.unforker", "method", "kustomizeBuild")) | |||
| func (l *Unforker) unforkBuild(kustomizePath string) ([]util.PostKustomizeFile, error) { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Rob0h
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Added a list length check to the render step - and only render the list if the length is nonzero.
How I Did it
How to verify it
Description for the Changelog
Empty kubernetes lists will not be included in ship output.
Picture of a Boat (not required but encouraged)