This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Fix empty value for env in helm values #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob0h
commented
Jan 8, 2019
| @@ -106,8 +106,7 @@ func (r *Resolver) DefaultHelmRelease(chartPath string, upstream string) api.Spe | |||
| ChartRoot: chartPath, | |||
| }, | |||
| ValuesFrom: &api.ValuesFrom{ | |||
| Path: constants.ShipPathInternalTmp, | |||
| SaveToState: true, | |||
There was a problem hiding this comment.
removing this is as helm values are saved during the helm values step
|
Could you verify that this doesn't cause a regression on the helm-stable charts? You'll need to run this: from an empty directory, with the It's not part of the automated test suite yet, I'm afraid |
laverya
approved these changes
Jan 9, 2019
| @@ -539,7 +539,7 @@ func fixLines(lines []string) []string { | |||
| // line has `env:` and nothing else but whitespace | |||
| if !checkIsChild(line, nextLine(idx, lines)) { | |||
| // next line is not a child, so env has no contents, add an empty object | |||
| lines[idx] = line + " {}" | |||
There was a problem hiding this comment.
I would prefer for you to delete this block entirely and modify arrayLineRegex (line 63) to include env
|
One final thing - should we add an integration test for the current kibana helm chart? Since that's what led to #777 being opened |
laverya
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Fix #777
How I Did it
SaveToStatefrom asset in default init lifecycleHow to verify it
kubectl apply -f rendered.yamlDescription for the Changelog
Fix empty value for env in helm values
Picture of a Boat (not required but encouraged)
🛶