This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
allow specifying the charset to use with the RandomString template function #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -14,3 +19,75 @@ func TestGenerateRandomString(t *testing.T) { | |||
| assert.Regexp(t, DefaultCharset, str) | |||
|
|
|||
| } | |||
|
|
|||
| func TestGenerateRandomStringTemplates(t *testing.T) { | |||
There was a problem hiding this comment.
Function TestGenerateRandomStringTemplates has 61 lines of code (exceeds 50 allowed). Consider refactoring.
ebramanti
approved these changes
Jan 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Extended the
RandomStringtemplate function to allow specifying the character set to useHow I Did it
By adding
, providedCharset ...stringto the function definition and using it if providedHow to verify it
Unit tests have been added to show that the function works without specifying a character set, and that a wide variety of specified character sets work.
Description for the Changelog
The
RandomStringtemplate function now optionally accepts a character set to usePicture of a Boat (not required but encouraged)