This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Fix UI for workflows with multiple async lifecycle steps #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob0h
commented
Dec 12, 2018
| const { startPollingStep, location, routeId } = this.props; | ||
| startPollingStep(location, routeId); | ||
| const { startPollingStep, currentRoute } = this.props; | ||
| if (currentRoute.phase === RENDER_PHASE) { |
There was a problem hiding this comment.
This logic is here for these async steps to guard against re-polling. These components are re-rendered as the transition happens to the next phase as we're directly outputting JSX from the renderStep in DetermineComponentForRoute
ebramanti
approved these changes
Dec 12, 2018
| routeId: "", | ||
| currentRoute: { | ||
| phase: TERRAFORM_PHASE, | ||
| id: "hotdog", |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
How I Did it
phasethat we are in (e.g.kubectl,terraform, etc.) Route phases are not unique as multiplekubectlsteps will have the samephase. In order to reconcile this, the routeidis now being used as it is unique to the each step.How to verify it
ship init fixtures/kubectl/ship.ymlto observe fixed functionalityship init fixtures/terraform/ship.yamlandship init ${helm_chart}Description for the Changelog
Picture of a Boat (not required but encouraged)
🛶