This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Add better debug output on proxied github pull failure. #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Add better debug output on proxied github pull failure.
How I Did it
Dump all the files we got in ReleaseMetadata into a debug log. Not using
JSON.Marshal because we want to explicitly exclude the contents and
writing a custom marshaller seems overkill.
How to verify it
Run a ship.yaml with 2 github assets in it, one valid and one that doesn't match up to actual
files in the repo. See a debug log line about what we did know about.
Description for the Changelog
Add better debug output on proxied github pull failure.
🛶