This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
designate Makefile NOTPARALLEL until we can make it parallellable #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
designated the top-level Makefile 'NOTPARALLEL' so that it will still build serially even if invoked with 'make -j' (which is how Homebrew likes to build)
How I Did it
Added a ".NOTPARALLEL:' target to the top of the makefile. This is a temporary step. I plan to dig in and add appropriate dependencies so that we can actually build parallel.
How to verify it
'make build' various targets to verify that serial builds still work fine
and 'make -j build' various targets to verify that parallel builds work fine (because they're now serialized)
Description for the Changelog
Picture of a Boat (not required but encouraged)