This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Auto focus TO_BE_MODIFIED in patch editor, fixed "add resource" button positioning #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Fixed the "Add Resource" button positioning on large file trees. It was hidden before, even if you scrolled down. Also updated the
handleGeneratePatchinKustomizeOverlay.jsxto focus and go to the patch line being edited.How I Did it
Add Resource fix: Updated CSS properties of
.add-new-resourceand..dirtree-wrapper.Auto focus fix: Use the
findandgoToLinemethods on AceEditorto get the position of the text being edited and then focus on it.How to verify it
Run ship init and go to the kustomize view. You can simulate a large file tree by adding more
<li>elements to the file tree. Click on a base line and type something in the patch.Description for the Changelog
Auto focus TO_BE_MODIFIED in patch editor.
Fixed "add resource" button positioning on large file trees.
Picture of a Boat (not required but encouraged)
⛵️