This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Move list yaml splitting to render #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebramanti
reviewed
Nov 19, 2018
pkg/lifecycle/daemon/daemon_test.go
Outdated
| @@ -194,6 +196,7 @@ func TestDaemonAPI(t *testing.T) { | |||
|
|
|||
| for _, test := range tests { | |||
| t.Run(test.name, func(t *testing.T) { | |||
| fmt.Println("name", test.name) | |||
| @@ -26,6 +27,16 @@ func (d *NavcycleRoutes) getStep(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| if preExecuteFunc, exists := d.PreExecuteFuncMap[step.ShortName()]; exists { | |||
| if err := preExecuteFunc(context.Background(), step); err != nil { | |||
There was a problem hiding this comment.
Should we be using background context here? What do these preExecuteFuncs do?
There was a problem hiding this comment.
OK, looks like your current use of this does not use context yet, but this is still worth considering before we merge.
There was a problem hiding this comment.
discussed irl - background context from the request handler is passed to pre execute funcs
ebramanti
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
How I Did it
rootFsto ensure proper location of overlaysHow to verify it
Description for the Changelog
Picture of a Boat (not required but encouraged)
🛶