This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Use helm to pull helm charts #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
reviewed
Aug 16, 2018
| @@ -0,0 +1,19 @@ | |||
| # nginx helm chart rendering example, using k8s.io/helm/docs/examples/nginx | |||
There was a problem hiding this comment.
probably doesn't matter, but this comment is off
dexhorthy
reviewed
Aug 16, 2018
| @@ -0,0 +1,2 @@ | |||
| this exists to create the charts directory | |||
| it should be removed when that bug is resolved | |||
There was a problem hiding this comment.
I don't understand this. Can this explain better or link to a full description?
There was a problem hiding this comment.
It really is a bug - #373
There was a problem hiding this comment.
(I'm editing the text to include a link to the github issue)
dexhorthy
reviewed
Aug 16, 2018
pkg/api/asset.go
Outdated
| @@ -79,7 +79,9 @@ type HelmAsset struct { | |||
| Values map[string]interface{} `json:"values" yaml:"values" hcl:"values"` | |||
| HelmOpts []string `json:"helm_opts" yaml:"helm_opts" hcl:"helm_opts"` | |||
| // GitHub references a github asset from which to pull the chart | |||
| GitHub *GitHubAsset `json:"github" yaml:"github" hcl:"github"` | |||
| GitHub *GitHubAsset `json:"github,omitempty" yaml:"github,omitempty" hcl:"github,omitempty"` | |||
| // HelmRef pulls a chart as Helm would | |||
There was a problem hiding this comment.
That sounds like a good name
dexhorthy
approved these changes
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Added a way for you to pull helm charts the same way that
helm fetchwould. Also relates to #292 (by importing a number of helm files rather than forking)How I Did it
Duplicated the
helm initandhelm fetchcommand line functionality as exported functions and used those within the helm asset.How to verify it
Look at the
helm-fetchintegration test.Description for the Changelog
Added
helm_fetchto thehelmasset, which fetches charts in the same way thehelm fetchcommand would.Picture of a Boat (not required but encouraged)