This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
integration tests ensure release exists #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
commented
Aug 15, 2018
| @@ -1 +0,0 @@ | |||
| {"v1":{"config":{"test_option":"abc123_test-option-value"}}} | |||
There was a problem hiding this comment.
this got deleted by accident I'll add it back
dexhorthy
commented
Aug 15, 2018
| var testOutputPath string | ||
| var testMetadata TestMetadata | ||
| var installationID string | ||
| customerEndpoint := os.Getenv("SHIP_INTEGRATION_CUSTOMER_ENDPOINT") |
There was a problem hiding this comment.
much is copypasta'd this stuff is new though
dexhorthy
commented
Aug 15, 2018
|
|
||
| if vendorToken != "" { | ||
| channelName := fmt.Sprintf("integration replicated.app %s", file.Name()) | ||
| createRelease(vendorEndpoint, vendorToken, testInputPath, testMetadata, channelName) |
There was a problem hiding this comment.
whoops, this needs to store the result in installationID
What I Did ------------ Add new integration tests, How I Did it ------------ - Add new integration test folder for `ship init replicated.app?customer_id=...&installation_id=...`, - Copy over 1 test, it still fails right now - e2e/vendor_client.go updates to support ensuring releases exist - have the replicated.app tests try to create the release from `input/.ship/release.yml` in graphql-api How to verify it ------------ ginkgo integration/init__replicated.app Description for the Changelog ------------ None :ship:
laverya
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Add new integration tests
How I Did it
ship init replicated.app?customer_id=...&installation_id=...,input/.ship/release.ymlin graphql-apiHow to verify it
ginkgo integration/init__replicated.app
Description for the Changelog
None
🚢