This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Ship should show human readable messages when running in headless #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevherro
force-pushed
the
headless-human-readable
branch
2 times, most recently
from
a25128e to
32141b4
Compare
kevherro
force-pushed
the
headless-human-readable
branch
from
32141b4 to
e2b92a1
Compare
kevherro
commented
Aug 9, 2018
| ProgressBuild = daemontypes.StringProgress("render", "build") | ||
| ProgressBackup = daemontypes.StringProgress("render", "backup") | ||
| ProgressExecute = daemontypes.StringProgress("render", "execute") | ||
| ProgressCommit = daemontypes.StringProgress("render", "commit") |
There was a problem hiding this comment.
Opted to merge these into a few human-readable messages. However, they have been preserved through debug logs below!
kevherro
requested review from
marccampbell and
dexhorthy
and removed request for
marccampbell
dexhorthy
approved these changes
Aug 9, 2018
marccampbell
reviewed
Aug 9, 2018
| @@ -56,6 +57,8 @@ func (s *Ship) Update(ctx context.Context) error { | |||
| // does a state file exist on disk? | |||
| existingState, err := s.State.TryLoad() | |||
|
|
|||
| s.Daemon.SetProgress(daemontypes.StringProgress("kustomize", `loading state from `+constants.StatePath)) | |||
There was a problem hiding this comment.
@kevinherro should this be the viper flag, not the constant?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Ship headless now prints human-readable progress messages!
Changed the behavior from this
to this
How I Did it
kustomize.go: added relevantship updatekustomizeprogress messagesrender.go: cleaned uprenderprogress messages. concatenated critical messages into human readable format and created debug logs for the remaining messagesHow to verify it
run
ship updateto see the progress messages printedRelated to Issue #266
Description for the Changelog
Picture of a Boat (not required but encouraged)
🛥