Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Update directory structure for ship init command #238

Merged

Conversation

ebramanti
Copy link
Contributor

@ebramanti ebramanti commented Aug 2, 2018

What I Did

This PR updates the directory structure of Helm charts after helm template is run.

How I Did it

  • Move files after helm template command is completed.
  • Improve debug log output of slice/struct values
  • Respond with 400 if empty keys for path/contents of Kustomize overlay

How to verify it

  • Tests have been updated to verify new additions still allow for normal logic to work

Description for the Changelog

  • Update directory structure for rendered Helm charts

Picture of a Boat (not required but encouraged)

@ebramanti ebramanti added the wip Work in progress label Aug 2, 2018
@ebramanti ebramanti force-pushed the ebramanti/ch13207/update-directory-structure-for-ship-init branch from cbf9de0 to a2b01fa Compare August 2, 2018 23:38
@ebramanti ebramanti force-pushed the ebramanti/ch13207/update-directory-structure-for-ship-init branch from a2b01fa to 409496f Compare August 2, 2018 23:43
Make sure template code is not specific to Helm chart pulling
@ebramanti ebramanti removed the wip Work in progress label Aug 3, 2018
@ebramanti ebramanti merged commit 06d471c into master Aug 3, 2018
@ebramanti ebramanti deleted the ebramanti/ch13207/update-directory-structure-for-ship-init branch August 3, 2018 17:19
ebramanti added a commit that referenced this pull request Aug 3, 2018
This fix was needed because of new folder structure in #238
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants