This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Write out kustomize overlays #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I Did ------------ After user finalizes kustomization step, write out overlays to the filesystem. How I Did it ------------ - move state behind an interface so we can mock it, add mockgen steps (interface is `Manager` old struct is called `MManager`, I would make the struct private but too many tests grab for it directly) - needed to tweak `specs.Resolver`/`ResolverTest` a little, but this should eventually use the mock instead - When user saves kustomize, load overlays from state, write each patch file, tracking each one and adding to `kustomization.yml` as well - add some basic testing for `lifecycle/kustomize#kustomizer` - rename `state.Overlay#Files` to `Patches` How to verify it ------------ Run `ship init` flow, see kustomize overlay written out Description for the Changelog ------------ Kustomize step writes overlays to output directory 
ebramanti
approved these changes
Aug 1, 2018
| @@ -27,6 +28,6 @@ func TestPersistSpec(t *testing.T) { | |||
| err := r.persistSpec(desiredSpec) | |||
| req.NoError(err) | |||
|
|
|||
| persistedSpec, err := r.StateManager.FS.ReadFile(".ship/release.yml") | |||
| persistedSpec, err := r.FS.ReadFile(".ship/release.yml") | |||
There was a problem hiding this comment.
Will have to rework this in my PR, we gotta figure out how we are going to organize filesystem path constants
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
After user finalizes kustomization step, write out overlays to the filesystem.
How I Did it
Managerold struct is calledMManager, I would make the struct private but too many tests grab for it directly)specs.Resolver/ResolverTesta little, but this should eventually use the mock insteadkustomization.ymlas welllifecycle/kustomize#kustomizerstate.Overlay#FilestoPatchesHow to verify it
Run
ship initflow, see kustomize overlay written outDescription for the Changelog
Kustomize step writes overlays to output directory