This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Move examples #202
Merged
Move examples #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
approved these changes
Jul 29, 2018
dexhorthy
reviewed
Jul 29, 2018
pkg/lifecycle/daemon/daemon.go
Outdated
| if serveUIFromAPIDaemon(d) { | ||
| g.Use(static.Serve("/", d.WebUIFactory("dist"))) | ||
| } | ||
| g.Use(static.Serve("/", d.WebUIFactory("dist"))) |
There was a problem hiding this comment.
This is gonna break console-ship
There was a problem hiding this comment.
This will only push to unstable, should we wait to merge until after console-ship has been updated to use docker run instead of docker-compose? Open to safest path here.
There was a problem hiding this comment.
Makes sense. Ok to merge then, but do you wanna also change port to 8800?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Moved fixtures out of examples. Examples will be used for examples on how to use ship, connecting into CI, gitops, etc.
How I Did it
mv&&git commitHow to verify it
Check out the examples directory
Description for the Changelog
Picture of a Boat (not required but encouraged)