Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

helm.github #131

Merged
merged 2 commits into from
Jul 4, 2018
Merged

helm.github #131

merged 2 commits into from
Jul 4, 2018

Conversation

dexhorthy
Copy link
Member

What I Did

Add support for assets.v1.helm.github

How I Did it

  • Refactored out CLIPlanner#githubStep into a github package so we can reuse it
  • Added a branch to helm#ChartFetcher to check for asset.GitHub and delegate to the github step, checking out to a local repo
  • docs, linter, etc

How to verify it

Write a spec with a helm asset that pulls from github:

assets:
  v1:
    - helm:
        dest: k8s/
        github:
          path: stable/cockroachdb
          repo: dexhorthy/charts
          ref: d5951228356f52d45c57bb3d794faecdd7677a2f
          source: public

Description for the Changelog

  • Add support for fetching helm charts from github via assets.v1.helm.github

@dexhorthy dexhorthy requested a review from laverya July 3, 2018 22:58
@dexhorthy dexhorthy merged commit 2dc6015 into replicatedhq:master Jul 4, 2018
@dexhorthy dexhorthy mentioned this pull request Jul 5, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laverya laverya laverya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexhorthy @laverya