This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
config chain integration tests #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case showing brokenness. Change "beta resolves to alpha" and "beta ignore override" tests to make live state != default hidden is not readonly apply saved state to writeable items only
the state files we are reading from and writing to do not have to be the same file
|
Code Climate has analyzed commit 30c56be and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 76.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.7% (0.3% change). View more on Code Climate. |
laverya
changed the title
divolgin
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Added an integration test for chained template functions and a related test to verify that saved state does not override readonly values. Changed headless daemon to not rely on persisting state to disk & to cache it in memory, just as the other daemons do.
How I Did it
Added integration tests. Changed headless daemon to also save state to internal variable & return that variable if it is not nil when reading state.
How to verify it
Description for the Changelog
Picture of a
BoatShip (not required but encouraged)