This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
docs for helm and dockerlayer #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
previously requested changes
Jun 18, 2018
hack/docs/mutations.json
Outdated
| { | ||
| "path": "properties.assets.properties.v1.items.properties.helm.properties.dest", | ||
| "merge": { | ||
| "description": "The directory in which to render the. If the source chart is at `charts/src/nginx`, and `dest` is set to `charts/rendered/`, then the chart will be templated at `charts/rendered/nginx`" |
hack/docs/mutations.json
Outdated
| { | ||
| "path": "properties.assets.properties.v1.items.properties.helm.properties.mode", | ||
| "merge": { | ||
| "description": "The unix permisions to set on the chart's parent directory" |
hack/docs/mutations.json
Outdated
| { | ||
| "path": "properties.assets.properties.v1.items.properties.dockerlayer.properties.mode", | ||
| "merge": { | ||
| "description": "The unix file permissions to be set on target unpack directory, e.g `777`" |
There was a problem hiding this comment.
Should this be 0777 for octal?
|
Code Climate has analyzed commit 5aa5783 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.4% (-0.2% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Added docs and schema for helm and dockerlayer assets
How I Did it
Add mutations.json entries for the two assets, regen schema and markdown
Replicated-lint and help-center prs coming soon
How to verify it
Read the new docs
Description for the Changelog
None, related to previous PR changes that already have descriptions.
Picture of a Boat (not required but encouraged)