-
Notifications
You must be signed in to change notification settings - Fork 70
asset support for unpacking a single docker layer #112
Conversation
"gopkg.in/yaml.v2" | ||
) | ||
|
||
func TestDeserialize(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function TestDeserialize
has 122 lines of code (exceeds 50 allowed). Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wontfix
} | ||
|
||
func (u *Unpacker) save( | ||
ctx context.Context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Unpacker.save
has 5 arguments (exceeds 4 allowed). Consider refactoring.
} | ||
|
||
func NewUnpacker( | ||
logger log.Logger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function NewUnpacker
has 5 arguments (exceeds 4 allowed). Consider refactoring.
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestUnpackLayer(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function TestUnpackLayer
has 70 lines of code (exceeds 50 allowed). Consider refactoring.
|
||
// NewStep gets a new Renderer with the default impl | ||
func NewStep( | ||
logger log.Logger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function NewStep
has 5 arguments (exceeds 4 allowed). Consider refactoring.
Code Climate has analyzed commit 1eea0d4 and detected 11 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 67.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.5% (-0.2% change). View more on Code Climate. |
I reviewed CC and they're all "this table test is too long" |
What I Did
How I Did it
DockerLayer
, which extendsDockerAsset
images
packagedocker
package asdocker.Renderer
so we can reuse it fordockerlayer
The Unpacker does the following:
docker save
the image to a tmp directorysecond tmp directory/<layer sha>/layer.tar
into the asset'sdest
Other stuff
How to verify it
examples/dockerlayer/packages.yml
dockerlayer
Description for the Changelog
Added support for
dockerlayer
assets, whichPicture of a Boat (not required but encouraged)