Merge pull request #1094 from replicatedhq/fix-is-visible-for-config-…

…items Use 'when' in addition to 'hidden' when checking the visiblity of a C…
replicatedhq · Dec 11, 2019 · 2948a7b · 2948a7b
2 parents 45a17f8 + e7a64f1
commit 2948a7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/web/init/package.json b/web/init/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@replicatedhq/ship-init",
-  "version": "1.6.13",
+  "version": "1.6.14",
   "description": "Shared component that contains the Ship Init app",
   "author": "Replicated, Inc.",
   "license": "Apache-2.0",

diff --git a/web/init/src/services/ConfigService.js b/web/init/src/services/ConfigService.js
@@ -114,7 +114,7 @@ export const ConfigService = {
   },
 
   isVisible(groups, obj) {
-    return !obj.hidden && ConfigService.isEnabled(groups, obj);
+    return !obj.hidden && obj.when !== "false" && ConfigService.isEnabled(groups, obj);
   },
 
   isEnabled(groups, obj) {