Merge pull request #1053 from alrs/fix-daemonless-dropped-error

pkg/lifecycle/kubectl: Fix swallowed error on DaemonlessKubectl.Execute
replicatedhq · Aug 27, 2019 · 0061de0 · 0061de0
2 parents abf7e61 + 933dac8
commit 0061de0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/lifecycle/kubectl/daemonless.go b/pkg/lifecycle/kubectl/daemonless.go
@@ -51,6 +51,10 @@ func (d *DaemonlessKubectl) Execute(ctx context.Context, release api.Release, st
 	debug := level.Debug(log.With(d.Logger, "step.type", "kubectl"))
 
 	cmd, err := d.prepareCmd(release, step)
+	if err != nil {
+		return errors.Wrap(err, "failed to prepare command for daemonless kubectl execution")
+	}
+
 	debug.Log("event", "kubectl.execute", "args", fmt.Sprintf("%+v", cmd.Args))
 
 	var stderr bytes.Buffer