Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts-configs to not reference the deleted "replay" package #621

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 10, 2024

Why didn't #616 catch this?

@bvaughn bvaughn requested a review from Andarist July 10, 2024 13:17
Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 66282b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

replay-io bot commented Jul 10, 2024

Status Complete ↗︎
Commit a3de6f7
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn bvaughn merged commit 9c54459 into main Jul 10, 2024
    7 checks passed
    @bvaughn bvaughn deleted the fix-tsconfig branch July 10, 2024 13:23
    @Andarist
    Copy link
    Member

    Why didn't #616 catch this?

    Hm, we don't really invoke tsc anymore on CI since the build is done through Rollup and I guess that my integration with the TS API there doesn't raise errors about this. Tbh, I'm not sure how to fix that there - I don't interact with project references directly in that script. So if it doesn't already throw an error... I probably wouldn't like to dive in there to figure it out.

    That said, we don't run tsc at all in the CI... that's a problem. I'll fix this in a moment

    @bvaughn
    Copy link
    Contributor Author

    bvaughn commented Jul 10, 2024

    That said, we don't run tsc at all in the CI... that's a problem. I'll fix this in a moment

    Yup! Definitely an oversight.

    I simultaneously wish our "Build, lint and test" task did more and less (it takes so long)

    @Andarist
    Copy link
    Member

    I wish it wouldn't use Earthly 🤣

    @bvaughn
    Copy link
    Contributor Author

    bvaughn commented Jul 10, 2024

    Yeah big same

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants