-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt "suspense" package #8884
Closed
Closed
Adopt "suspense" package #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ QA Wolf - Deploy PRSpencer here: 4 tests ran, see details here. |
E2E Tests58 replays were recorded for 315db6f. 40 Failedbreakpoints-07: rewind and seek using command bar and console messages
18 Passed
breakpoints-06: Test log point in a sourcemapped file
Snapshot Tests68 replays were recorded for 315db6f. 68 Failedshould add this keyword to the list of suggestions
|
bvaughn
force-pushed
the
bvaughn/suspense
branch
from
March 9, 2023 18:28
c59b275
to
731238a
Compare
This was referenced Mar 9, 2023
bvaughn
added a commit
that referenced
this pull request
Mar 13, 2023
First piece of PR #8884. That PR is very large so I will be landing it in a few smaller pieces. This first piece will set some foundation: * Install "suspense" package v0.0.25 * Replace and delete redundant internal structures * Re-name misspelled "thennable"s to "thenable" * Replace isThennable with isPromiseLike from "suspense" * Replace internal Wakeable/createWakeable with Deferred/createDeferred from "suspense" * Replace internal Record with Record from "suspense" * Replaced internal record "status" constants with ones from from "suspense" * Update fixture data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useIndexedDB
hookcreateGenericCache
createUseGetValue
createGenericRangeCache
WeakRef
usage where necessary (e.g. object preview cache)getKey
functions anytime there's a non primitive param