Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LoggerUtil.ts #2984

Merged
merged 2 commits into from
Oct 2, 2024
Merged

refactor: LoggerUtil.ts #2984

merged 2 commits into from
Oct 2, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Oct 2, 2024

Description

We're importing the logger like this:
import { pino } from '@walletconnect/logger'

This causes the webpack bundlers to throw an CommonJS module error

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 2, 2024 0:14am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 2, 2024 0:14am

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 0ac445b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-utils Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 245.04999999999998% 4252 / 18816
🔵 Statements 245.04999999999998% 4252 / 18816
🔵 Functions 261.14% 329 / 1001
🔵 Branches 312.37% 593 / 1267
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit-utils/src/LoggerUtil.ts 0% 0% 0% 0% 1, 3-7, 9-11, 13-19, 21-22, 24-26
Generated in workflow #6507 for commit 0ac445b by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 2, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-DUX7miNj.js 1883.905 538.224
assets/index.js 9.63 3.161
assets/index2.js 11.589 3.212
assets/w3m-modal.js 7.452 2.629
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.525
index.html 0.329 0.236
Total Size 2428.565 703.495

Base Size

Name Size (kb) Gzip (kb)
assets/index-DUX7miNj.js 1883.905 538.224
assets/index.js 9.63 3.161
assets/index2.js 11.589 3.212
assets/w3m-modal.js 7.452 2.629
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.525
index.html 0.329 0.236
Total Size 2428.565 703.495

@magiziz magiziz merged commit b5444bd into main Oct 2, 2024
17 checks passed
@magiziz magiziz deleted the refactor/logger-imports branch October 2, 2024 14:05
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
@magiziz magiziz linked an issue Oct 2, 2024 that may be closed by this pull request
@magiziz magiziz changed the title refactor: Loggerutil.ts refactor: LoggerUtil.ts Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Appkit not working with Nextjs anymore - { pino } import error
3 participants