Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v5 default options #2935

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix: v5 default options #2935

merged 3 commits into from
Sep 30, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Sep 25, 2024

Description

This PR sets default AppKit options into a constant and changes enableAnalytics to true by default.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 9238126

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 30, 2024 0:38am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 30, 2024 0:38am

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 88.35000000000001% 3405 / 13827
🔵 Statements 88.35000000000001% 3405 / 13827
🔵 Functions 165.67000000000002% 252 / 743
🔵 Branches 216.6% 471 / 900
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/base/src/client.ts 0% 0% 0% 0% 1, 28-30, 39, 42, 49, 51-52, 55, 57-60, 62-64, 67-70, 72-75, 77-79, 82-84, 86-88, 90-92, 94-96, 98-100, 102-104, 106-108, 110-112, 114-116, 118-120, 122-125, 127-130, 132-134, 136-138, 140-142, 144-146, 148-150, 152-154, 156-158, 160-162, 164-166, 168-170, 172-174, 176-178, 180-182, 184-186, 188-190, 192-194, 196-200, 202-204, 206, 208-211, 213-219, 221-226, 228, 230-232, 234-236, 238-240, 242-244, 246-248, 250-252, 254, 256-261, 263-264, 266-267, 269-271, 273-275, 277-279, 281-282, 284-286, 288-289, 291-296, 298-303, 305-310, 312-315, 317-322, 324-325, 327-330, 332-333, 335-337, 339-341, 343-344, 346-347, 349-351, 354-359, 361-363, 366-367, 370-373, 375, 377, 380-382, 384-394, 396-398, 400-402, 404-406, 408-410, 412, 415-421, 423-434, 436-438
packages/core/src/controllers/ApiController.ts 92.17% 73.91% 80% 92.17% 56-57, 71-72, 129-130, 142, 257-261, 277-282
packages/core/src/controllers/OptionsController.ts 54.54% 100% 28.57% 54.54% 120-121, 124-125, 132-135, 153-154, 157-158, 161-162, 165-166, 169-170, 173-174, 177-181, 192-195, 198-202, 205-209, 212-213, 216-219
packages/core/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
Generated in workflow #6443

Copy link
Contributor

github-actions bot commented Sep 25, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-ByZAEcIQ.js 1607.759 466.106
assets/noble-curves.js 31.941 12.781
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index.js 9.517 3.192
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.281
assets/walletconnect-ethereum-provider.js 454.329 141.408
assets/index4.js 11.601 3.207
assets/w3m-modal.js 6.988 2.506
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.586
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.238
Total Size 2731.428 811.769

Base Size

Name Size (kb) Gzip (kb)
assets/index-ByZAEcIQ.js 1607.759 466.106
assets/noble-curves.js 31.941 12.781
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index.js 9.517 3.192
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.281
assets/walletconnect-ethereum-provider.js 454.329 141.408
assets/index4.js 11.601 3.207
assets/w3m-modal.js 6.988 2.506
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.586
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.238
Total Size 2731.428 811.769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants