Support swift 3.0 #347
Closed
Support swift 3.0 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to swift1.2
Fix Immutable set generation
Remove user info
Conflicts: templates/machine.swift.motemplate
* rentzsch/master: (61 commits) [CHANGELOG] 1.30.1 [VERSION] 1.30.1 Adding check if modules are available on compiletime for import statements in machine header. (Fixing rentzsch#325) [FIX] Bracket scalars with will/didChange & will/didAccess. [TYPO] Create-an-issue link Add space between property type and name. Added pull request & issue templates. 10.11 SDK but 10.10 min deployment [DEV] does OS X 10.10 make Travis happy? @import Foundation on machine templates. Cleaned up rakefile arguments. Cleaned up test suite to pass on both ObjC & Swift Remove additionalHeaderFileName from Swift template Moved Obj-C code to independent directory Update ObjC test to ARC. Clean up Obj-C Rakefile tests Fix deprecation warning in test.m DOC FIX Make Travis badge clickable [DOC] Make Travis badge clickable. Made constants more const ... # Conflicts: # RegexKitLite.h # RegexKitLite.m # nsenumerate.h # templates/human.swift.motemplate # templates/machine.swift.motemplate # test/HumanMO.h # test/HumanMO.m # test/MyProtocol.h # test/TestProtocol.h # test/TestProtocol.m # test/test.m
* rentzsch/master: (61 commits) [CHANGELOG] 1.30.1 [VERSION] 1.30.1 Adding check if modules are available on compiletime for import statements in machine header. (Fixing rentzsch#325) [FIX] Bracket scalars with will/didChange & will/didAccess. [TYPO] Create-an-issue link Add space between property type and name. Added pull request & issue templates. 10.11 SDK but 10.10 min deployment [DEV] does OS X 10.10 make Travis happy? @import Foundation on machine templates. Cleaned up rakefile arguments. Cleaned up test suite to pass on both ObjC & Swift Remove additionalHeaderFileName from Swift template Moved Obj-C code to independent directory Update ObjC test to ARC. Clean up Obj-C Rakefile tests Fix deprecation warning in test.m DOC FIX Make Travis badge clickable [DOC] Make Travis badge clickable. Made constants more const ...
* rentzsch/master: Allow for nullable collection properties Make entityInManagedObjectContext: nullable
* rentzsch/master: test: remove justin’s coded message for help Fix syntax errors in Objective-C templates (missing multiple `]`’s) test: add failing Parent.orderedChildren ordered relationship Add nullability to the primitive value
Migrate to swift 3.0 mogenerator
|
Why are all the file modes changed? |
rentzsch
requested changes
Sep 22, 2016
There was a problem hiding this comment.
Oh hey, look at this fancy new Github Review feature. I'll try it out now, excuse any bumps in the road:
- Let's not change the mode of every file unless there's a compelling reason?
- Why did Swift user info keys get removed?
- Adding open to everything looks good (assuming I understand the semantics correctly)
- We need to get Travis passing somehow. I'm not sure how to tell it this needs Swift 3 off the bat.
|
Towards the final point: looks like https://github.com/rentzsch/mogenerator/blob/master/.travis.yml
|
It is very strange, because I tried to replace the files form the original repository and it did not help.
I returned back to this logic
Unfortunately for the test that does not work :( |
rentzsch
added a commit
that referenced
this pull request
Sep 26, 2016
|
I moved the test along by specifying we need the 10.12 SDK, which is apparently required for Xcode 8 on Travis CI. There's now a whole bunch of new Swift 3-related errors: https://travis-ci.org/rentzsch/mogenerator/builds/162673879 I don't put up with Swift shit, so someone else needs to fix this if mogenerator is ever to support Swift 3. |
|
Sorry, didn't mean to close this PR. |
|
Oops, forgot to mention I created a simplified commit of this branch / Pull Request on master. So work should proceed on current master. |
|
Well looks like you dont't like Swift anymore, Calling a "Swift Shit" is not a good sign bro. |
|
Closing this since full Swift 3 landed in #349 |
vladimirgoncharov
added a commit
to vladimirgoncharov/mogenerator
that referenced
this pull request
Nov 14, 2016
* rentzsch/master: Support for “Uses Scalar Type”. Swift 3 NSData to Data [CHANGELOG] 1.31 [VERSION] 1.31 Template Updated With Latest OS X Swift 3 Changes Swift 3 NSDate to Date Swift 3 Making Optional first parameters in one to many relation travis: use 10.12 SDK [NEW] Swift 3 support. [Goncharov Vladimir](rentzsch#347) # Conflicts: # templates/machine.swift.motemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.