Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when skipping an attribute named 'type' #165

Merged
merged 1 commit into from
Jul 3, 2013
Merged

Add a warning when skipping an attribute named 'type' #165

merged 1 commit into from
Jul 3, 2013

Conversation

simonwhitaker
Copy link
Contributor

Just spent a fun ten minutes with git bisect figuring out why mogenerator was chomping my setPrimitiveType: method. This pull request is for the benefit of our children and our children's children. :)

rentzsch added a commit that referenced this pull request Jul 3, 2013
[CHANGE] Add a warning when skipping an attribute named 'type'. (Simon Whitaker)
@rentzsch rentzsch merged commit 5bfc6d6 into rentzsch:master Jul 3, 2013
@rentzsch
Copy link
Owner

rentzsch commented Jul 3, 2013

Sorry about that, Simon. Thanks for taking the time to help our children and our children's children :)

@simonwhitaker
Copy link
Contributor Author

No problem! I wasn't being snarky by the way, it really was fun. git bisect is my favourite bit of git and I don't get to use it very often.

@simonwhitaker simonwhitaker deleted the add-type-attribute-warning branch July 4, 2013 05:27
ddrccw pushed a commit to ddrccw/mogenerator that referenced this pull request Jan 20, 2014
…-warning

[CHANGE] Add a warning when skipping an attribute named 'type'. (Simon Whitaker)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants