Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An entity property called 'type' causes App Store rejection #74

Closed
mbogh opened this issue Sep 30, 2011 · 4 comments
Closed

An entity property called 'type' causes App Store rejection #74

mbogh opened this issue Sep 30, 2011 · 4 comments

Comments

@mbogh
Copy link

mbogh commented Sep 30, 2011

Hello,

First of all, really nice work. I use this on all my projects which involve CoreData.

Yesterday an app of mine got rejected by Apple due to the use of private APIs. Apple's reply:
"We found the following non-public API in your app:

setPrimitiveType:

If you have defined methods in your source code with the same names as the above-mentioned APIs, we suggest altering your method names so that they no longer collide with Apple's private APIs to avoid your application being flagged in future submissions."

I don't know what the best solution is but either somekind of warning to the user or renaming the setPrimitiveXXX methods.

Best regards
mbogh

@rentzsch
Copy link
Owner

Agreed! Closing as a duplicate of #16.

@seanm
Copy link
Contributor

seanm commented Jul 22, 2015

I just got around to updating from 1.27 to 1.28 and got a warning message that directed me to this issue.

I can certainly understand the motivation for this change, and I know Apple can be obstinate wrt their App Store, but this change sucks for me, because I use "type" in many places, and have been doing so since 10.5 with no problem (I don't use App Store). I guess I could rename the next time I change my model, but don't want to do a persistent migration just for such a rename.

Would you accept a patch that adds an option to continue to log the warning but doesn't actually skip the generation? Thanks.

@rentzsch
Copy link
Owner

@seanm sure, I'd accept such a patch.

seanm added a commit to seanm/mogenerator that referenced this issue Aug 26, 2015
…’ attributes

- Removed noninheritedAttributesSansType method
- Changed noninheritedAttributes method to warn upon ‘type’ attribute
@seanm
Copy link
Contributor

seanm commented Aug 26, 2015

@rentzsch, I've given it a stab, please review... thanks.

seanm added a commit to seanm/mogenerator that referenced this issue Aug 26, 2015
…’ attributes

- Removed noninheritedAttributesSansType method
- Changed noninheritedAttributes method to warn upon ‘type’ attribute
DaveWoodCom added a commit to DaveWoodCom/mogenerator that referenced this issue Sep 11, 2016
…Is: primitiveValue`, similar to rentzsch#74 and rentzsch#16, so this avoids generating `primativeValue` methods

Wonder if it would be better to amend the main code base similar to this commit?:
rentzsch@cd9809d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants