-
Notifications
You must be signed in to change notification settings - Fork 395
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't generate -primativeType and -setPrimativeType:. Closes #202.
- Loading branch information
Showing
3 changed files
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is brakes models if we have attribute with name "type".
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, mogenerator's test/test.xcdatamodel's Child has a
type
attribute also ofint16_t
and HEAD passes the tests.4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed it for me. Thanks.
@XBeg9 To get this fix, make sure to install with
brew install --HEAD mogenerator
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rentzsch maybe you could release this as 1.28.1? It is almost 4 months since last release, and this fix is important enough to release it IMO. What do you think?
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree 100%, just ran into this.
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also ran into this issue! Please release 1.28.1.
Even worse: brew install --HEAD mogenerator has a problem with ordered relations -> generates a unordered property to access the relation :(
4ef709c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a workaround, you could rename your attribute to have a prefix, like
activityType
. That will solve your issues faster than demanding a fix.