Chore: Allow 000*.rpy files in renpy/common #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckdoom4
approved these changes
May 7, 2023
2 tasks
duckdoom4
pushed a commit
that referenced
this pull request
May 12, 2023
duckdoom4
pushed a commit
that referenced
this pull request
Jun 1, 2023
duckdoom4
pushed a commit
that referenced
this pull request
Jun 2, 2023
duckdoom4
pushed a commit
that referenced
this pull request
Jun 2, 2023
duckdoom4
added a commit
that referenced
this pull request
Jun 2, 2023
* Chore: Allow 000*.rpy files in renpy/common (#300) * RunRenpyViaplugin (#291) * Edited extensions method to add way to run renpy * Added the command to the pallete via json * Adding debug config to allow renpy to be played from play button * changed type to cmd * reformatted with prettier * This format might work? * Refactored if statement to make it more readable * Refactoring of folder names and chaning if statements * This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement * reformated through magical means... God I hate switching computers * Reformated with the correct file, please ignore previous one * Ignore dist folder (#303) * Ignore dist folder (#301) * Chore(Enhancement) - Add a command that cleans up compiled files. * Update the command title to match the convention. * Use await/async syntax * Merge pull request #304 from a2937/old-file-command Chore(Enhancement) - Add a command that cleans up compiled files. --------- Co-authored-by: a2937 <a.rcottrill521@gmail.com> Co-authored-by: seanj29 <88255342+seanj29@users.noreply.github.com> Co-authored-by: Daniel Luque <danielluque14@gmail.com>
duckdoom4
added a commit
that referenced
this pull request
Jun 2, 2023
* Chore: Allow 000*.rpy files in renpy/common (#300) * RunRenpyViaplugin (#291) * Edited extensions method to add way to run renpy * Added the command to the pallete via json * Adding debug config to allow renpy to be played from play button * changed type to cmd * reformatted with prettier * This format might work? * Refactored if statement to make it more readable * Refactoring of folder names and chaning if statements * This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement * reformated through magical means... God I hate switching computers * Reformated with the correct file, please ignore previous one * Ignore dist folder (#303) * Ignore dist folder (#301) * Chore(Enhancement) - Add a command that cleans up compiled files. * Update the command title to match the convention. * Use await/async syntax * Adds PR ci to master Fixes #306 * Fixes codeql-analysis.yml format * Adds setup action * Fix package lock after merge --------- Co-authored-by: a2937 <a.rcottrill521@gmail.com> Co-authored-by: seanj29 <88255342+seanj29@users.noreply.github.com> Co-authored-by: Daniel Luque <danielluque14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: Allow 000*.rpy files in renpy/common
Description:
Prevents a 000*.rpy file from the Renpy SDK from being highlighted in red with the error message
Filenames must begin with a letter or number, but may not begin with '00' as Ren'Py uses such files for its own purposes.. A file is determined to be part of the sdk if it is under "renpy/common".Related Issue:
Closes #283