Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): ensure order for cached pr's on gitea and bitbucket #33373

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 2, 2025

Changes

Reverse the cached pr list, so renovate finds the most recent PR first.

Context

Currently the cache returns pr's in accending order, so renovate always finds the oldest PR if multiple match.
So it opens new PR's event if a newer PR was already closed.
We do this sorting on github pr cache.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title fix(platform): ensure order for cached pr's on gitea and bitbucket fix(platform): ensure order for cached pr's on gitea and bitbucket cloud Jan 2, 2025
@viceice viceice changed the title fix(platform): ensure order for cached pr's on gitea and bitbucket cloud fix(platform): ensure order for cached pr's on gitea and bitbucket Jan 2, 2025
@viceice viceice added platform:bitbucket Bitbucket Cloud platform platform:gitea Gitea or Forgejo platforms labels Jan 2, 2025
@viceice viceice enabled auto-merge January 2, 2025 16:28
@viceice
Copy link
Member Author

viceice commented Jan 2, 2025

I think it's very unlikely that a user closes a newer renovate PR and then re-opens an older PR.

@viceice viceice added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit e811b23 Jan 2, 2025
41 checks passed
@viceice viceice deleted the fix/platform-pr-cache-order branch January 2, 2025 16:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.88.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:bitbucket Bitbucket Cloud platform platform:gitea Gitea or Forgejo platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants