feat(datasource/orb): Add support for internal CircleCI Registries #33213
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglazer
changed the title
mglazer
changed the title
viceice
reviewed
Dec 19, 2024
rarkins
previously approved these changes
Dec 20, 2024
viceice
reviewed
Dec 20, 2024
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
rarkins
approved these changes
Dec 20, 2024
viceice
approved these changes
Dec 20, 2024
|
🎉 This PR is included in version 39.79.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enables CircleCI Orb datasource to use additional registries.
Context
The current implementation prevented using additional registries, I suspect because most people are not self-hosting
CircleCI. This just enables support for this use case. Note that this is separate from the current private orb support which still requires hosting the orbs on the Internet facing CircleCI instance.
This was a pretty simple commit, but took me an inordinately long time to test because I hit a number of extremely weird issues running renovate locally on OSX. Everything seemed to work when I switched to an Ubuntu VM though.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: