Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gradle-wrapper): simplify utils and related tests #31432

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Sep 16, 2024

Changes

Post-processing to #31319:

  • getJavaConstraint()
    • extract major for better readability and change >= to === in places where the condition can never be >=
    • remove no longer needed GlobalConfig.set({ binarySource: 'docker' }); from tests and consolidate them
  • extractGradleVersion()
    • use multi-line regex instead of line-by-line parsing
    • add real tests so that utils by itself now has full coverage

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Sep 17, 2024
Merged via the queue into renovatebot:main with commit 65b867a Sep 17, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.85.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants