refactor: use yaml instead of js-yaml for parsing YAML files #31336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Sep 11, 2024
6 tasks
viceice
previously approved these changes
Sep 16, 2024
viceice
approved these changes
Sep 16, 2024
|
🎉 This PR is included in version 38.84.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces
js-yamlwithyamlas the former has not received updates in the last 3 years.Also this library supports adding tag handling, which would allow us to natevily handle
!referencetags in GitlabCIContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: