Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pypi): support GCloud credentials for Google Artifact Registry #31262

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Sep 6, 2024

Changes

Make use of getGoogleAuthToken to populate Authorization header if registry is Google Artifact Registry (.pkg.dev)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Sep 10, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason this is only scoped at Python packages?

I guess pkg.dev has other registries outside of Python packages too.

lib/modules/datasource/pypi/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/pypi/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/pypi/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/pypi/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/pypi/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/pypi/index.spec.ts Outdated Show resolved Hide resolved
@maxbrunet
Copy link
Contributor Author

maxbrunet commented Sep 13, 2024

Thank you for the review @viceice ❤️

Any specific reason this is only scoped at Python packages?

Time and need

I guess pkg.dev has other registries outside of Python packages too.

Yes1, Renovate already has support in the docker and maven datasources.

Footnotes

  1. https://cloud.google.com/artifact-registry/docs/supported-formats

@rarkins rarkins added this pull request to the merge queue Sep 14, 2024
Merged via the queue into renovatebot:main with commit 0049a94 Sep 14, 2024
38 checks passed
@HonkingGoose
Copy link
Collaborator

This PR is accidentally breaking our release step on the main branch, see Discussion:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants