-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pypi): support GCloud credentials for Google Artifact Registry #31262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
Sep 7, 2024
maxbrunet
force-pushed
the
feat/pypi/google-auth
branch
from
September 7, 2024 18:38
f2754db
to
653d7ce
Compare
rarkins
previously approved these changes
Sep 10, 2024
secustor
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason this is only scoped at Python packages?
I guess pkg.dev
has other registries outside of Python packages too.
viceice
reviewed
Sep 12, 2024
viceice
requested changes
Sep 12, 2024
maxbrunet
force-pushed
the
feat/pypi/google-auth
branch
from
September 13, 2024 15:01
408af96
to
689a619
Compare
maxbrunet
force-pushed
the
feat/pypi/google-auth
branch
from
September 13, 2024 15:03
689a619
to
701e780
Compare
viceice
approved these changes
Sep 14, 2024
This PR is accidentally breaking our |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make use of
getGoogleAuthToken
to populateAuthorization
header if registry is Google Artifact Registry (.pkg.dev
)Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: