Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib/data): move metadata-manual to lib/data #30260

Merged
merged 5 commits into from
Jul 30, 2024
Merged

refactor(lib/data): move metadata-manual to lib/data #30260

merged 5 commits into from
Jul 30, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jul 20, 2024 •
edited
Loading

Changes

  • move metadata-manual (ie. changelog & source url data) to lib/data
  • divide the changelogUrl and sourceUrl data into separate json files
  • update lib/data/readme

Context

Part Of: #29942

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 20, 2024 06:53
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 23, 2024 14:35
secustor
secustor reviewed Jul 25, 2024
View reviewed changes
lib/data/readme.md Outdated Show resolved Hide resolved
lib/data/readme.md Outdated Show resolved Hide resolved
viceice
viceice reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the mentioned docs changes

@rarkins rarkins enabled auto-merge July 30, 2024 12:00
@rarkins
Copy link
Collaborator

rarkins commented Jul 30, 2024

@secustor I'm leaving one unresolved conversation of yours so that you have a chance to review

@rarkins rarkins added this pull request to the merge queue Jul 30, 2024
Merged via the queue into renovatebot:main with commit 5d262a9 Jul 30, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor approved these changes

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RahulGautamSingh @rarkins @renovate-release @viceice @secustor