Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enabled json imports #30223

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • resolveJsonModule -> true
  • we still want to import package.json dynamically, so used dynamic string in the require, this prevents ts compiler from inclusing package.json in the dist folder after compilation

Context

Related: #29942
It is necessary so that we can include json files in the lib folder and import them using static json import. Else, TS won't include the json files in the dist folder after compilation

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@viceice viceice added this pull request to the merge queue Jul 17, 2024
Merged via the queue into renovatebot:main with commit 2dfc542 Jul 17, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.433.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants